This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
WIP karknu/acceptance workarounds #3657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit recovery mode when streaming is supported. The most difficult block received is tracked and use it to decide if we should exit recovery mode similar to they way batch mode leaves recovery.
Don't merge!
rvl
reviewed
Sep 25, 2018
| , walletListen ? "127.0.0.1:8090" | ||
| , walletDocListen ? "127.0.0.1:8091" | ||
| , ekgListen ? "127.0.0.1:8000" | ||
| , walletListen ? "localhost:8090" |
There was a problem hiding this comment.
This is no longer needed because #3658 fixed the issue.
It's also good to sometimes test IP addresses rather than hostnames because this is something users (exchanges) like to do.
| @@ -46,7 +46,7 @@ in | |||
|
|
|||
| ${utf8LocaleSetting} | |||
| echo Launching wallet node: ${wallet} | |||
| ${wallet} &> ${stateDir}/logs/wallet.log & | |||
| ${wallet} --runtime-args " --legacy-wallet +RTS -M6G" &> ${stateDir}/logs/wallet.log & | |||
There was a problem hiding this comment.
This is already implemented by #3626
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
Linked issue
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)