[CO-373] Move wallet@Pos.Util.Mnemonic to wallet-new@Cardano.Wallet.Kernel.BIP39

[Anviking]

Description

The old wallet code should be removed. This pr moves Mnemonic from wallet to wallet-new as BIP39.

At the same time I replaced the TestVector tuple with record wildcards in the contained BIP39Spec.hs. Feel free to disagree.

Note Probably easiest to view changes per commit rather than all at once. The first commit merely moves/copies, while subsequent commits make the important changes.

Would make sense to squash everything later.

Depends on #3667.

Linked issue

CO-373

Type of change

• 🐞 Bug fix (non-breaking change which fixes an issue)
• 🛠 New feature (non-breaking change which adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
• 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
• 🔨 New or improved tests for existing code
• ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

• I have read the style guide document, and my code follows the code style of this project.
• If my code deals with exceptions, it follows the guidelines.
• I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
• CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

• I have added tests to cover my changes.
• All new and existing tests passed.

QA Steps

Screenshots (if available)

[Anviking]

Actually, I've broken stuff in cardano-sl-faucet Investigating

I've missed

faucet/src/Cardano/Faucet/Init.hs:import           Pos.Util.Mnemonic (Mnemonic, entropyToMnemonic, genEntropy)
faucet/src/Cardano/Faucet/Types/Config.hs:import           Pos.Util.Mnemonic (Mnemonic)
scripts/generate-mnemonic.hs:import           Pos.Util.Mnemonic (EntropySize, Mnemonic, entropyToMnemonic,
tools/src/Pos/Tools/Dbgen/Lib.hs:import           Pos.Util.Mnemonic (Mnemonic, entropyToMnemonic, genEntropy)
wallet-new/bench/Client/Cardano/Wallet/Web/Endpoint/NewWallet.hs:import           Pos.Util.Mnemonic (Mnemonic, entropyToMnemonic, genEntropy)

fixing

Hm, Dbgen might be a bit tricky…

[KtorZ]

Same here.

[Anviking]

We then get problems since wallet and wallet-new are using different Mnemonic types.

/Users/Johannes/IOHK/cardano-sl/wallet-new/src/Cardano/Wallet/API/V1/LegacyHandlers/Wallets.hs:93:64: error:
    • Couldn't match expected type ‘Pos.Util.Mnemonic.Mnemonic 12’
                  with actual type ‘Cardano.Wallet.Kernel.BIP39.Mnemonic 12’
      NB: ‘Cardano.Wallet.Kernel.BIP39.Mnemonic’ is defined at
            src/Cardano/Wallet/Kernel/BIP39.hs:(84,1)-(87,25)
          ‘Pos.Util.Mnemonic.Mnemonic’
            is defined in ‘Pos.Util.Mnemonic’
                in package ‘cardano-sl-wallet-1.3.0’
    • In the first argument of ‘V0.CBackupPhrase’, namely
        ‘backupPhrase’
      In the second argument of ‘V0.CWalletInit’, namely
        ‘(V0.CBackupPhrase backupPhrase)’
      In the expression:
        V0.CWalletInit initMeta (V0.CBackupPhrase backupPhrase)
   |
93 |     let walletInit = V0.CWalletInit initMeta (V0.CBackupPhrase backupPhrase)
   |                                                                ^^^^^^^^^^^^

[KtorZ]

Meh. That's exactly why I wanted to remove all those modules first :/ ...
Fine then, but let's only replace the minimum to make stuff compile and wait for the external handlers to be moved

[KtorZ]

LGTM overall.

Few remarks about the commits though:

• 00b3e20 and 2db81b2 should be squashed together
• 3e39033 should have a proper description explaining the reason of deletion (and why it is safe / done at this moment).

Will do while merging.

[KtorZ]

runTests [] 😅 ... talking about useless tests huh?
No big deal though.