Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CO-403] Remove wallet dependency from Cardano/Wallet/Server/Plugins.hs #3686

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

parsonsmatt
Copy link
Contributor

@parsonsmatt parsonsmatt commented Sep 28, 2018

Description

Linked issue

[CO-403]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

Copy link
Contributor

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KtorZ KtorZ changed the title [CO-403] Remove the reference to the old wallet [CO-403] Remove wallet dependency from Cardano/Wallet/Server/Plugins.hs Oct 1, 2018
@KtorZ KtorZ merged commit 5847c34 into CO-372/TheGreatCleanup Oct 1, 2018
@KtorZ KtorZ deleted the matt/co-403/remove-wallet-dep branch October 1, 2018 08:12
KtorZ added a commit that referenced this pull request Oct 1, 2018
…et-dep

[CO-403] Remove `wallet` dependency from `Cardano/Wallet/Server/Plugins.hs`
@KtorZ KtorZ mentioned this pull request Oct 1, 2018
12 tasks
KtorZ added a commit that referenced this pull request Oct 2, 2018
…et-dep

[CO-403] Remove `wallet` dependency from `Cardano/Wallet/Server/Plugins.hs`
KtorZ added a commit that referenced this pull request Oct 3, 2018
…et-dep

[CO-403] Remove `wallet` dependency from `Cardano/Wallet/Server/Plugins.hs`
KtorZ added a commit that referenced this pull request Oct 4, 2018
…et-dep

[CO-403] Remove `wallet` dependency from `Cardano/Wallet/Server/Plugins.hs`
KtorZ added a commit that referenced this pull request Oct 8, 2018
…et-dep

[CO-403] Remove `wallet` dependency from `Cardano/Wallet/Server/Plugins.hs`
KtorZ added a commit that referenced this pull request Oct 11, 2018
KtorZ added a commit that referenced this pull request Oct 22, 2018
KtorZ added a commit that referenced this pull request Oct 31, 2018
KtorZ added a commit that referenced this pull request Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants