This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-1113] Buildkite: Add Windows build #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
devops-1113-buildkite-windows-release
branch
from
9d7c8bd
to
e947292
Compare
angerman
approved these changes
Nov 21, 2018
|
Hmm... not so fast I guess: |
angerman
reviewed
Nov 21, 2018
| copy log-configs\daedalus.yaml daedalus\log-config-prod.yaml | ||
| copy lib\configuration.yaml daedalus\ | ||
| copy lib\*genesis*.json daedalus\ | ||
| copy cardano-launcher.exe daedalus\ |
There was a problem hiding this comment.
are we in $env:WORK_DIR?
Can we do copy $env:WORK_DIR\cardano-launcher.exe daedalus\?
There was a problem hiding this comment.
Yes we are in $env:WORK_DIR but I don't want to touch this bit because it works and produces a zip with the expected layout.
This is a squash of the changes on the buildkite/windows branch, without deleting appveyor.yml, without the setup script, and with ghc 8.2.2 instead of 8.4.4. Original authors: Jacob Mitchell <jacob.mitchell@iohk.io> Samuel Leathers <samuel.leathers@iohk.io> Rodney Lorrimar <rodney.lorrimar@iohk.io>
rvl
force-pushed
the
devops-1113-buildkite-windows-release
branch
from
e947292
to
a312801
Compare
|
Also, are the ~6min buidkite/windows build seem suspicious. Shouldn't a full build take much much longer? |
|
Thanks - I force-pushed the review fixes. The build failed quickly in 6 minutes because I accidentally left a ghc-8.4.4 option on the build command line. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a squash of the changes in #3802, without deleting
appveyor.yml, without the setup script, and with ghc 8.2.2 instead of 8.4.4.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1113
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1138
Type of change
QA Steps