Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-1112] Staging application version #3936

Merged
merged 4 commits into from
Dec 7, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Dec 6, 2018

Description

Update the applicationVersion for the staging installers, but revert the part which changes the lastKnownBlockVersion for the staging cluster. This must be 0.2.0 not 0.1.0.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1112

@rvl rvl requested a review from a team December 6, 2018 13:04
@jbgi
Copy link
Contributor

jbgi commented Dec 6, 2018

the test that fails:

Failures:

  test/unit/Test/Spec/GetTransactions.hs:475:29:
  1) Wallet unit tests, GetTransactions, newTransaction and getTransactions return the same result
       Falsifiable (after 3 tests):
       expected: [Transaction {txId = AbstractHash 96b6abd8fa47c007e622612d04896b6e8a63a29999b47ebe55811e26c4641c77, txConfirmations = 0, txAmount = Coin {getCoin = 180223}, txInputs = PaymentDistribution {pdAddress = Address {addrRoot = AbstractHash 9f4e8abc67d2a2b1a98ebf0d86de4ec9fd87616a25ae3368189d496c, addrAttributes = Attributes { data: AddrAttributes {aaPkDerivationPath = Just (HDAddressPayload {getHDAddressPayload = "\b\163vSp!}\204U7)\204\240\172`~\238\b\246\225\166\175\137\139\DC16RL"}), aaStakeDistribution = BootstrapEraDistr, aaNetworkMagic = NetworkMainOrStage} }, addrType = ATPubKey}, pdAmount = Coin {getCoin = 1288}} :| [PaymentDistribution {pdAddress = Address {addrRoot = AbstractHash bafed403e7b5e2dc8bbe696b0817bd2c204d8774d71e12fc07e525d5, addrAttributes = Attributes { data: AddrAttributes {aaPkDerivationPath = Just (HDAddressPayload {getHDAddressPayload = "\b\163vSp!}\201K\183`\204\&8)\SI\SI0i\NUL[\140|\185\229\223\243\134\223"}), aaStakeDistribution = BootstrapEraDistr, aaNetworkMagic = NetworkMainOrStage} }, addrType = ATPubKey}, pdAmount = Coin {getCoin = 940606611}}], txOutputs = PaymentDistribution {pdAddress = Address {addrRoot = AbstractHash e99446d3281e133e3e655d3e4600ed28c785c3cb9eda795939e201fd, addrAttributes = Attributes { data: AddrAttributes {aaPkDerivationPath = Just (HDAddressPayload {getHDAddressPayload = "\b\163vSp!}\138Y2\ETB\204\155\232\&6\195FT\212`\134\243\ACKr\217\154*\181"}), aaStakeDistribution = BootstrapEraDistr, aaNetworkMagic = NetworkMainOrStage} }, addrType = ATPubKey}, pdAmount = Coin {getCoin = 940427676}} :| [PaymentDistribution {pdAddress = Address {addrRoot = AbstractHash b95e6f10e7a123b42cace1783b52c808effd4af0caa06648fc2f7635, addrAttributes = Attributes { data: AddrAttributes {aaPkDerivationPath = Just (HDAddressPayload {getHDAddressPayload = ""}), aaStakeDistribution = UnsafeMultiKeyDistr (fromList [(AbstractHash 0d4c5eaf1d203d4ba09fef4dc36813c8ec87262415a6aec6d5ca810b,CoinPortion {getCoinPortion = 273008156499864}),(AbstractHash 0ddf16c504f57834bfffa861a16625ec864febdeab3e834c0952f7c7,CoinPortion {getCoinPortion = 595787640989827}),(AbstractHash 1ad384a87b555a86b31daddfa7472eb876741c7a716b2b62383bb2e4,CoinPortion {getCoinPortion = 131204202510309})]), aaNetworkMagic = NetworkMainOrStage} }, addrType = ATPubKey}, pdAmount = Coin {getCoin = 100}}], txType = ForeignTransaction, txDirection = OutgoingTransaction, txCreationTime = 12340000, txStatus = Applying}]
        but got: [Transaction {txId = AbstractHash 96b6abd8fa47c007e622612d04896b6e8a63a29999b47ebe55811e26c4641c77, txConfirmations = 0, txAmount = Coin {getCoin = 180223}, txInputs = PaymentDistribution {pdAddress = Address {addrRoot = AbstractHash bafed403e7b5e2dc8bbe696b0817bd2c204d8774d71e12fc07e525d5, addrAttributes = Attributes { data: AddrAttributes {aaPkDerivationPath = Just (HDAddressPayload {getHDAddressPayload = "\b\163vSp!}\201K\183`\204\&8)\SI\SI0i\NUL[\140|\185\229\223\243\134\223"}), aaStakeDistribution = BootstrapEraDistr, aaNetworkMagic = NetworkMainOrStage} }, addrType = ATPubKey}, pdAmount = Coin {getCoin = 940606611}} :| [PaymentDistribution {pdAddress = Address {addrRoot = AbstractHash 9f4e8abc67d2a2b1a98ebf0d86de4ec9fd87616a25ae3368189d496c, addrAttributes = Attributes { data: AddrAttributes {aaPkDerivationPath = Just (HDAddressPayload {getHDAddressPayload = "\b\163vSp!}\204U7)\204\240\172`~\238\b\246\225\166\175\137\139\DC16RL"}), aaStakeDistribution = BootstrapEraDistr, aaNetworkMagic = NetworkMainOrStage} }, addrType = ATPubKey}, pdAmount = Coin {getCoin = 1288}}], txOutputs = PaymentDistribution {pdAddress = Address {addrRoot = AbstractHash e99446d3281e133e3e655d3e4600ed28c785c3cb9eda795939e201fd, addrAttributes = Attributes { data: AddrAttributes {aaPkDerivationPath = Just (HDAddressPayload {getHDAddressPayload = "\b\163vSp!}\138Y2\ETB\204\155\232\&6\195FT\212`\134\243\ACKr\217\154*\181"}), aaStakeDistribution = BootstrapEraDistr, aaNetworkMagic = NetworkMainOrStage} }, addrType = ATPubKey}, pdAmount = Coin {getCoin = 940427676}} :| [PaymentDistribution {pdAddress = Address {addrRoot = AbstractHash b95e6f10e7a123b42cace1783b52c808effd4af0caa06648fc2f7635, addrAttributes = Attributes { data: AddrAttributes {aaPkDerivationPath = Just (HDAddressPayload {getHDAddressPayload = ""}), aaStakeDistribution = UnsafeMultiKeyDistr (fromList [(AbstractHash 0d4c5eaf1d203d4ba09fef4dc36813c8ec87262415a6aec6d5ca810b,CoinPortion {getCoinPortion = 273008156499864}),(AbstractHash 0ddf16c504f57834bfffa861a16625ec864febdeab3e834c0952f7c7,CoinPortion {getCoinPortion = 595787640989827}),(AbstractHash 1ad384a87b555a86b31daddfa7472eb876741c7a716b2b62383bb2e4,CoinPortion {getCoinPortion = 131204202510309})]), aaNetworkMagic = NetworkMainOrStage} }, addrType = ATPubKey}, pdAmount = Coin {getCoin = 100}}], txType = ForeignTransaction, txDirection = OutgoingTransaction, txCreationTime = 12340000, txStatus = Applying}]

Randomized with seed 313132966

@rvl
Copy link
Contributor Author

rvl commented Dec 7, 2018

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 7, 2018
3936: [DEVOPS-1112] Staging application version r=rvl a=rvl

## Description

Update the applicationVersion for the staging installers, but revert the part which changes the `lastKnownBlockVersion` for the staging cluster. This must be `0.2.0` not `0.1.0`.

## Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1112


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 7, 2018

Timed out

@cleverca22
Copy link
Contributor

bors r+ p=10

iohk-bors bot added a commit that referenced this pull request Dec 7, 2018
3936: [DEVOPS-1112] Staging application version r=cleverca22 a=rvl

## Description

Update the applicationVersion for the staging installers, but revert the part which changes the `lastKnownBlockVersion` for the staging cluster. This must be `0.2.0` not `0.1.0`.

## Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1112


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
@rvl rvl merged commit 593f79c into release/2.0.0 Dec 7, 2018
@iohk-bors iohk-bors bot deleted the devops-1112-staging-application-version branch December 7, 2018 09:22
iohk-bors bot added a commit that referenced this pull request Dec 21, 2018
3972: Cherry-picks from release/2.0.0 branch to develop r=rvl a=rvl

These are cherry-picks of the PRs: #3811 #3816 #3817 #3831 #3846 #3867 #3879 #3883 #3919 #3934 #3936 #3946 #3962.

Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
Co-authored-by: Michael Hueschen <michael.hueschen@iohk.io>
Co-authored-by: Alexander Diemand <codieplusplus@apax.net>
Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Co-authored-by: Rupert Horlick <rupert.horlick@iohk.io>
Co-authored-by: Luke Nadur <luke.nadur@iohk.io>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Co-authored-by: Marcin Szamotulski <marcin.szamotulski@iohk.io>
Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
Co-authored-by: Jean-Christophe Mincke <jeanchristophe.mincke@gmail.com>
@KtorZ KtorZ mentioned this pull request Jan 4, 2019
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants