Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

API V1 types: Wallet-related types logging improving #348

Merged
merged 1 commit into from
Feb 19, 2019
Merged

API V1 types: Wallet-related types logging improving #348

merged 1 commit into from
Feb 19, 2019

Conversation

denisshevchenko
Copy link
Contributor

@denisshevchenko denisshevchenko commented Feb 19, 2019 •
edited
Loading

#315

Overview

  • I have improved logging output for Wallet-related API types.

Comments

@denisshevchenko denisshevchenko mentioned this pull request Feb 19, 2019
Open
11 tasks
@denisshevchenko denisshevchenko self-assigned this Feb 19, 2019
@denisshevchenko
Copy link
Contributor Author

denisshevchenko commented Feb 19, 2019 •
edited
Loading

Examples of new logging output.

Wallet:

Wallet
  wallet id: J7rQqaLLHBFPrgJXwpktaMB1B1kQBXAyc2uRSfRPzNVGiv6TdxBzkPNBUWysZZZdhFG9gRy3sQFfX5wfpLbi4XTFGFxTg
  name: My wallet
  balance: 21112193039365805 coin(s)
  created at: 1600003111541388
  assurance level: normal
  has spending password: False

NewWallet:

Request for new wallet
  operation: restore
  name: My Wallet
  assurance level: normal

WalletUpdate:

Update for wallet
  name: My Wallet
  assurance level: normal

KtorZ
KtorZ approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@denisshevchenko denisshevchenko merged commit 3a4fa89 into develop Feb 19, 2019
@denisshevchenko denisshevchenko deleted the denisshevchenko/315/api-v1-wallet-types-logging branch February 19, 2019 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@uroboros uroboros Awaiting requested review from uroboros

@akegalj akegalj Awaiting requested review from akegalj

Assignees

@denisshevchenko denisshevchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denisshevchenko @KtorZ