This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
HdRootBase <-> HdAccountBase #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
changed the title
KtorZ
changed the base branch from
develop
to
KtorZ/357/restructure-pool-construction
KtorZ
force-pushed
the
KtorZ/357/restructure-bip-44-hdroot
branch
from
d60c1db to
05e23ee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#357
Overview
HdRootBasein a similar fashion to how we had theHdAccountBaseHdRootIdwith thisHdRootBaseHdAccountBasein favorHdRootBaseComments
@denisshevchenko This has grown a bit bigger than I thought, and I ended up doing some deeper restructuring in the end :| ... I'll try to split the PR into smaller ones to isolate the relevant changes.Done.