This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
clean-up access to encrypted secret keys and address pools construction #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of some upcoming restructuring where we get rid of the HdAccountBase and replace it with an HdRootBase. This will ultimately remove a lot of errors linked to the possible inconsistency we could get across all accounts of a root. This particular restructuring move some responsibility to the callers of getESK and getPools and purify a bit those primitives functions. This way, we leave to the caller to decide what to do when something goes wrong. In this particular case, we fail hard with an invariant violation
| :: DB | ||
| -> HdAccountId | ||
| -> [(Address, Word32)] | ||
| addressesByAccountId' _db accId = addressesByAccountId db accId |
There was a problem hiding this comment.
If the first argument is not used - why do we need it? Maybe just remove _db?
| -- NOTE: | ||
| -- We arbitrarily take the maximum AddressPoolGap here. This is rather | ||
| -- incorrect but will go away with the next PR as part of #357! | ||
| externallyOwnedRoots |
There was a problem hiding this comment.
Maybe we have to unify our naming? I mean that in some places we use a full form externallyOwned, but in other places we use a short one, EO...
| invariantFO :: HdRootId -> Maybe a -> IO a | ||
| invariantFO rootId = flip maybe return $ fail $ toString $ | ||
| "Cardano.Wallet.Kernel.BListener: invariant violation: encrypted secret key \ | ||
| \hasn't been found for the given root id: " <> sformat build rootId |
There was a problem hiding this comment.
Maybe just match explicitly?
invariantFO :: HdRootId -> Maybe a -> IO a
invariantFO rootId (Just k) = return k
invariantFO rootId Nothing = fail $ toString $
"Cardano.Wallet.Kernel.BListener: invariant violation: encrypted secret key \
\hasn't been found for the given root id: " <> sformat build rootId
And the same for invariantEO..
denisshevchenko
approved these changes
Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#357
Overview
This is in preparation of some upcoming restructuring where we get rid of the HdAccountBase and replace it with an HdRootBase. This will ultimately remove a lot of errors linked to the possible
inconsistency we could get across all accounts of a root.
This particular restructuring move some responsibility to the callers of getESK and getPools and
purify a bit those primitives functions. This way, we leave to the caller to decide what to do
when something goes wrong. In this particular case, we fail hard with an invariant violation
Comments