Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

API V1 types: Address-related types logging improving. #361

Merged
merged 1 commit into from
Feb 26, 2019
Merged

API V1 types: Address-related types logging improving. #361

merged 1 commit into from
Feb 26, 2019

Conversation

denisshevchenko
Copy link
Contributor

@denisshevchenko denisshevchenko commented Feb 25, 2019 •
edited
Loading

#315

Overview

  • I have improved logging for Address-related API V1 types.

Comments

@denisshevchenko denisshevchenko self-assigned this Feb 25, 2019
@denisshevchenko
Copy link
Contributor Author

denisshevchenko commented Feb 25, 2019 •
edited
Loading

Examples.

NewAddress:

Request for new address
  wallet id: J7rQqaLL...XTFGFxTg
  account index: 2874182981

Please note that improved logging for types WalAddress and WalletAddress was introduced in previous PR (#358).

@denisshevchenko denisshevchenko mentioned this pull request Feb 25, 2019
Open
11 tasks
Anviking
Anviking reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wondering about unusedAddressValidity

src/Cardano/Wallet/API/V1/Types.hs Show resolved Hide resolved
src/Cardano/Wallet/API/V1/Types.hs Show resolved Hide resolved
src/Cardano/Wallet/API/V1/Types.hs Outdated Show resolved Hide resolved
@denisshevchenko denisshevchenko force-pushed the denisshevchenko/315/api-v1-address-types-logging branch from 0bf7325 to 630d489 Compare February 25, 2019 13:16
@Anviking
Copy link
Member

Anviking commented Feb 26, 2019 •
edited
Loading

Minor/not important now: I would have put the remove-unused-types in a separate commit.

@denisshevchenko denisshevchenko merged commit 143e6d0 into develop Feb 26, 2019
@denisshevchenko denisshevchenko deleted the denisshevchenko/315/api-v1-address-types-logging branch February 26, 2019 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Anviking Anviking Anviking approved these changes

@akegalj akegalj Awaiting requested review from akegalj

@KtorZ KtorZ Awaiting requested review from KtorZ

Assignees

@denisshevchenko denisshevchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denisshevchenko @Anviking