Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: openapi lint #152

Merged
merged 51 commits into from
Jan 18, 2024
Merged

feat: openapi lint #152

merged 51 commits into from
Jan 18, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 11, 2024

Description

Adding OpenAPI linting

Related Issue(s)

Link to this issue input-output-hk/catalyst-voices#143

Description of Changes

  • Add spectral rule set including
  • Add check OpenAPI lint target
  • Create BUILD_SPECTRAL function and base_spectral target
  • Add example of OpenAPI json file
  • Add spectral / JSON and YAML linter document
  • Change cat-ci version to v2.2.3

Related Pull Requests

Link to this PR input-output-hk/catalyst-voices#208

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn changed the title Feat: openapi lint feat: openapi lint Jan 11, 2024
@bkioshn bkioshn marked this pull request as draft January 11, 2024 08:38
@bkioshn bkioshn marked this pull request as ready for review January 16, 2024 06:51
stevenj
stevenj previously approved these changes Jan 18, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkioshn bkioshn added the enhancement New feature or request label Jan 18, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit e31df10 into master Jan 18, 2024
51 checks passed
@stevenj stevenj deleted the feat/openapi-lint branch January 18, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants