Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): Proposal setup section #1177

Merged
merged 22 commits into from
Nov 18, 2024
Merged

feat(cat-voices): Proposal setup section #1177

merged 22 commits into from
Nov 18, 2024

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Nov 8, 2024 •
edited by damian-molinski
Loading

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

Resovles #1176, #842

Description of Changes

  • creating new widget for Guidance Card
  • creating new widget for Messages Card
  • add simple dummy data to demonstrate cards content.
  • guidance has three filter types: education, tips, and mandatory cards (Filter states: All, education, tips, mandatory)
  • each theme has a internal ranking (1,2,3, - lowest number first) - 1 mandatory, 2 education, 3 tips

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added do not merge yet PR is not ready to be merged yet do not review yet Do not review yet ux/ui UX/UI related issues labels Nov 8, 2024
@LynxLynxx LynxLynxx self-assigned this Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ Test Report | ${\color{lightgreen}Pass: 324/324}$ | ${\color{red}Fail: 0/324}$ |

@LynxLynxx LynxLynxx marked this pull request as ready for review November 11, 2024 12:53
@LynxLynxx LynxLynxx requested a review from minikin as a code owner November 11, 2024 12:53
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 324/324}$ | ${\color{red}Fail: 0/324}$ |

@LynxLynxx LynxLynxx added review me PR is ready for review and removed do not review yet Do not review yet do not merge yet PR is not ready to be merged yet labels Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 331/331}$ | ${\color{red}Fail: 0/331}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 331/331}$ | ${\color{red}Fail: 0/331}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 331/331}$ | ${\color{red}Fail: 0/331}$ |

damian-molinski
damian-molinski reviewed Nov 14, 2024
View reviewed changes
catalyst_voices/apps/voices/lib/pages/workspace/workspace_setup_panel.dart Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/workspace/workspace_setup_panel.dart Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/workspace/workspace_setup_panel.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/workspace/workspace_setup_panel.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/workspace/workspace_setup_panel.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/widgets/navigation/sections_controller.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/widgets/navigation/sections_controller.dart Show resolved Hide resolved
catalyst_voices/packages/internal/catalyst_voices_localization/lib/l10n/intl_en.arb Outdated Show resolved Hide resolved
...voices/packages/internal/catalyst_voices_view_models/lib/src/proposal/guidance/guidance.dart Show resolved Hide resolved
...voices/packages/internal/catalyst_voices_view_models/lib/src/proposal/guidance/guidance.dart Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

damian-molinski
damian-molinski reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then devtools_options.yaml looks good

catalyst_voices/apps/voices/devtools_options.yaml Outdated Show resolved Hide resolved
@LynxLynxx
chore: update .gitignore to exclude devtools_options.yaml and remove …
9491332 
…obsolete files from voices and uikit_example directories
damian-molinski
damian-molinski previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski
Delete catalyst_voices/packages/internal/catalyst_voices_localization…
76dc552 
…/lib/generated/catalyst_voices_localizations.dart
@damian-molinski
Delete catalyst_voices/packages/internal/catalyst_voices_localization…
21e2471 
…/lib/generated/catalyst_voices_localizations_en.dart
@damian-molinski
Delete catalyst_voices/packages/internal/catalyst_voices_localization…
73f6e4f 
…/lib/generated/catalyst_voices_localizations_es.dart
@damian-molinski damian-molinski added the dart Pull requests that update Dart code label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@damian-molinski damian-molinski merged commit d7db9f8 into main Nov 18, 2024
33 checks passed
@damian-molinski damian-molinski deleted the feature/1176_proposal_section branch November 18, 2024 14:30
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@minikin minikin Awaiting requested review from minikin minikin is a code owner

@dtscalac dtscalac Awaiting requested review from dtscalac

Assignees

@LynxLynxx LynxLynxx

Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LynxLynxx @damian-molinski @dtscalac