Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: catalyst-gateway docs generation cli command #136

Merged
merged 7 commits into from
Nov 10, 2023
Merged

feat: catalyst-gateway docs generation cli command #136

merged 7 commits into from
Nov 10, 2023

Conversation

Mr-Leshiy
Copy link
Contributor

Description

  • Added new docs cli command for catalyst-gateway to generate docs in json or yaml format
  • Some refactoring

Related Issue(s)

Closes #99

saibatizoku
saibatizoku previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

stevenj
stevenj requested changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the ticket, the implementation doesn't follow its requirements.

catalyst-gateway/bin/src/logger.rs Show resolved Hide resolved
catalyst-gateway/bin/src/settings.rs Outdated Show resolved Hide resolved
catalyst-gateway/bin/src/service/docs/mod.rs Outdated Show resolved Hide resolved
catalyst-gateway/bin/src/cli.rs Outdated Show resolved Hide resolved
catalyst-gateway/bin/src/service/poem_service.rs Outdated Show resolved Hide resolved
stevenj
stevenj requested changes Nov 10, 2023
View reviewed changes
catalyst-gateway/bin/src/settings.rs Outdated Show resolved Hide resolved
@Mr-Leshiy Mr-Leshiy requested a review from stevenj November 10, 2023 13:57
stevenj
stevenj approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj enabled auto-merge (squash) November 10, 2023 13:57
@stevenj stevenj merged commit b0e2c4a into main Nov 10, 2023
11 checks passed
@stevenj stevenj deleted the feat/api-docs-gen branch November 10, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@minikin minikin Awaiting requested review from minikin

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Mr-Leshiy @saibatizoku @stevenj