New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cat-voices): Another batch of onboarding tests #1472

Merged

oldGreg5 merged 14 commits into main from 1453-continue-automating-onboarding

Jan 8, 2025

Contributor

oldGreg5 commented Jan 7, 2025 •

edited

Loading

Description

Another batch of onboarding tests

Related Issue(s)

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module

oldGreg5 added 2 commits

January 3, 2025 17:43

wip

cb1db46


          Merge branch 'refs/heads/main' into 1453-continue-automating-onboarding

00375c5

oldGreg5 requested review from dtscalac, damian-molinski and LynxLynxx as code owners

January 7, 2025 09:20

oldGreg5 linked an issue

that may be closed by this pull request

🛠️ [TASK] : Integration tests, continue automating onboarding flow, part 2 #1453

Closed

Contributor

github-actions bot commented Jan 7, 2025

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |


          add next button checking

Contributor

github-actions bot commented Jan 7, 2025

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

oldGreg5 added 2 commits

January 7, 2025 12:28


          formatting

258a93d


          Merge branch 'main' into 1453-continue-automating-onboarding

f500f5a

oldGreg5 requested review from emiride and kukkok3

January 7, 2025 11:45

Contributor

github-actions bot commented Jan 7, 2025

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

Contributor

github-actions bot commented Jan 7, 2025

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |


          Merge branch 'main' into 1453-continue-automating-onboarding

e798eb7

Contributor

github-actions bot commented Jan 7, 2025

✅ Test Report | ${\color{lightgreen}Pass: 371/371}$ | ${\color{red}Fail: 0/371}$ |

minikin assigned oldGreg5


          Merge branch 'main' into 1453-continue-automating-onboarding

4178b0c

oldGreg5 enabled auto-merge (squash)

January 7, 2025 13:03

oldGreg5 disabled auto-merge

January 7, 2025 13:03

Contributor

github-actions bot commented Jan 7, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

damian-molinski reviewed

View reviewed changes

catalyst_voices/apps/voices/integration_test/pageobject/onboarding_page.dart Show resolved Hide resolved

kukkok3 added the review me label

oldGreg5 requested a review from damian-molinski

January 8, 2025 06:25

damian-molinski previously approved these changes

View reviewed changes

Contributor

damian-molinski left a comment

Looks good to me


          Merge branch 'refs/heads/main' into 1453-continue-automating-onboarding

fd39d77

Contributor

github-actions bot commented Jan 8, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |


          Merge branch 'main' into 1453-continue-automating-onboarding

9c7407d

Contributor

github-actions bot commented Jan 8, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

oldGreg5 added 2 commits

January 8, 2025 12:17


          Merge remote-tracking branch 'origin/1453-continue-automating-onboard…

0dc3473

…ing' into 1453-continue-automating-onboarding


          few more onboarding tests

82a1133

oldGreg5 dismissed damian-molinski’s stale review via

82a1133

January 8, 2025 11:19

Contributor

github-actions bot commented Jan 8, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

Contributor

github-actions bot commented Jan 8, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

Contributor

emiride commented Jan 8, 2025

LGTM

emiride previously approved these changes

View reviewed changes


          fix styling

ef96b0b

oldGreg5 dismissed emiride’s stale review via

ef96b0b

January 8, 2025 12:33

Contributor

github-actions bot commented Jan 8, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

Contributor

github-actions bot commented Jan 8, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |


          fix styling

c9455df

oldGreg5 requested a review from emiride

January 8, 2025 14:07

oldGreg5 enabled auto-merge (squash)

January 8, 2025 14:08

oldGreg5 changed the title ~~test(cat-voices): Another bach of onboarding tests~~ test(cat-voices): Another batch of onboarding tests

Contributor

github-actions bot commented Jan 8, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |


          fix styling

35f02f4

emiride approved these changes

View reviewed changes

oldGreg5 merged commit 3ef4a42 into main

33 checks passed

oldGreg5 deleted the 1453-continue-automating-onboarding branch

January 8, 2025 14:37

Contributor

github-actions bot commented Jan 8, 2025

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

emiride emiride approved these changes

damian-molinski damian-molinski left review comments

dtscalac Awaiting requested review from dtscalac dtscalac is a code owner

LynxLynxx Awaiting requested review from LynxLynxx LynxLynxx is a code owner

kukkok3 Awaiting requested review from kukkok3

Labels