Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fronted): add catalyst_voices_localization pub #155

Merged
merged 8 commits into from
Nov 23, 2023

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Nov 20, 2023

Description

Create a localization package to encapsulate localization.

Related Issue(s)

Closes #74

Description of Changes

  • Create catalyst_voices_localization
  • Integrate localization in the app

Breaking Changes

NONE

Video

CleanShot.2023-11-22.at.16.20.35.mp4

Out of scope

Dart code generation on CI/CD

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@minikin minikin added do not review yet Do not review yet draft Draft labels Nov 20, 2023
@minikin minikin self-assigned this Nov 20, 2023
@minikin minikin marked this pull request as ready for review November 22, 2023 13:45
@minikin minikin removed do not review yet Do not review yet draft Draft labels Nov 22, 2023
@minikin minikin enabled auto-merge (squash) November 22, 2023 13:47
@minikin minikin requested a review from stevenj November 22, 2023 15:27
@minikin minikin added the review me PR is ready for review label Nov 22, 2023
@minikin minikin added this to the M4: Voting & Delegation milestone Nov 22, 2023
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@minikin minikin merged commit a17bd81 into main Nov 23, 2023
32 checks passed
@minikin minikin deleted the feat/add-catalyst_voices_localization branch November 23, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ste-up initial internationalization
2 participants