Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve fornted app architecure #158

Merged
merged 15 commits into from
Nov 28, 2023
Merged

feat: improve fornted app architecure #158

merged 15 commits into from
Nov 28, 2023

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Nov 24, 2023 •
edited
Loading

Description

Improve frontend app architecture.

Related Issue(s)

Description of Changes

Improve frontend app architecture by isolating components in separate packages.

Breaking Changes

NONE

Screenshots

Not applicable

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@minikin minikin self-assigned this Nov 24, 2023
@minikin minikin added draft Draft do not review yet Do not review yet labels Nov 24, 2023
@minikin minikin added review me PR is ready for review and removed do not review yet Do not review yet draft Draft labels Nov 28, 2023
@minikin minikin marked this pull request as ready for review November 28, 2023 14:58
@minikin minikin requested a review from stevenj as a code owner November 28, 2023 14:58
stevenj
stevenj approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 1a9e795 into main Nov 28, 2023
24 checks passed
@stevenj stevenj deleted the feature/add-state-managment branch November 28, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

Assignees

@minikin minikin

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update project structure to follow best architecture practices frontend
2 participants
@minikin @stevenj