Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle DB schema version mismatch #197

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Dec 29, 2023

Description

Updates catalyst-gateway service GET /health/ready endpoint, such that when a DB schema version mismatch happens, the service becomes unavailable, and should recover when the expected version is in place.

Related Issue(s)

List the issue numbers related to this pull request.

Closes #47

Description of Changes

Provide a clear and concise description of what the pull request changes.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku marked this pull request as draft December 29, 2023 00:38
@saibatizoku saibatizoku self-assigned this Dec 29, 2023
@saibatizoku saibatizoku added the do not merge yet PR is not ready to be merged yet label Dec 29, 2023
@saibatizoku saibatizoku marked this pull request as ready for review December 29, 2023 00:43
@saibatizoku saibatizoku changed the title feat: set State variable for schema version check status feat: Handle DB schema version mismatch Dec 29, 2023
@minikin minikin merged commit 5701c81 into main Dec 29, 2023
22 checks passed
@minikin minikin deleted the feature/schema-mismatch-disables-service branch December 29, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : cat-gateway health endpoint to probe schema version
2 participants