Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openapi info section #209

Merged
merged 8 commits into from
Jan 17, 2024
Merged

fix: openapi info section #209

merged 8 commits into from
Jan 17, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 17, 2024

Description

Fix cat-gateway openAPI info section to follow the v3.0.0 schema.
For reference, please refer to v3.0.0

Related Issue(s)

Closes #143

Description of Changes

  • Remove summary and identifier

Related Pull Requests

#208

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Jan 17, 2024
Mr-Leshiy
Mr-Leshiy previously approved these changes Jan 17, 2024
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but
Please point the PR to main and ensure that CI is passing.

@bkioshn bkioshn changed the base branch from feat/openapi-lint to main January 17, 2024 09:12
@bkioshn bkioshn dismissed Mr-Leshiy’s stale review January 17, 2024 09:12

The base branch was changed.

@bkioshn bkioshn requested a review from stevenj January 17, 2024 09:34
@stevenj stevenj merged commit fdbe65e into main Jan 17, 2024
20 checks passed
@stevenj stevenj deleted the fix/openapi-info branch January 17, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add OpenAPI linting to our CI process.
3 participants