Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update poems #220

Merged
merged 24 commits into from
Jan 30, 2024
Merged

fix: update poems #220

merged 24 commits into from
Jan 30, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 26, 2024 •
edited
Loading

Description

Update poems' related dependencies.

Description of Changes

  • Update
    • poem to v2.0.0
    • poem-openapi to v4.0.0
    • poem-extensions to v0.8.0
  • Fix all issues related to the updates
  • Ignoring the integration test for now because of the network connection panic

Breaking Changes

Updating Rust to a stable version 1.75.0 and other dependencies causes some syntax changes

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn marked this pull request as draft January 26, 2024 08:17
@minikin minikin added the draft Draft label Jan 26, 2024
@bkioshn bkioshn self-assigned this Jan 26, 2024
@bkioshn bkioshn marked this pull request as ready for review January 26, 2024 15:41
@bkioshn bkioshn added review me PR is ready for review and removed draft Draft labels Jan 26, 2024
saibatizoku
saibatizoku previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

catalyst-gateway/bin/src/event_db/queries/event/proposal.rs Outdated Show resolved Hide resolved
Mr-Leshiy
Mr-Leshiy requested changes Jan 29, 2024
View reviewed changes
catalyst-gateway/Cargo.toml Outdated Show resolved Hide resolved
catalyst-gateway/Earthfile Outdated Show resolved Hide resolved
@minikin minikin enabled auto-merge (squash) January 29, 2024 10:12
apskhem
apskhem reviewed Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@bkioshn bkioshn requested a review from Mr-Leshiy January 30, 2024 07:53
@bkioshn bkioshn requested a review from Mr-Leshiy January 30, 2024 11:39
Mr-Leshiy
Mr-Leshiy approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 6dbd897 into main Jan 30, 2024
21 checks passed
@minikin minikin deleted the fix/update-poems branch January 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apskhem apskhem apskhem left review comments

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@saibatizoku saibatizoku saibatizoku left review comments

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@minikin minikin Awaiting requested review from minikin minikin is a code owner

Assignees

@bkioshn bkioshn

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bkioshn @saibatizoku @Mr-Leshiy @apskhem @minikin