Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: openapi specification #229

Merged
merged 22 commits into from
Feb 7, 2024
Merged

fix: openapi specification #229

merged 22 commits into from
Feb 7, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Feb 2, 2024 •
edited by kukkok3
Loading

Description

Correct any issues the linter picks up in the catalyst-gateway API.

Related Issue(s)

Closes #143 Fix #227

Related Pull Requests

#208

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Feb 2, 2024
@bkioshn bkioshn added documentation Pull requests that update a dependency file. enhancement New feature or request labels Feb 2, 2024
FelipeRosa
FelipeRosa reviewed Feb 2, 2024
View reviewed changes
Copy link

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, otherwise, LGTM

catalyst-gateway/bin/src/service/common/objects/account_votes.rs Outdated Show resolved Hide resolved
@bkioshn bkioshn added the review me PR is ready for review label Feb 5, 2024
Mr-Leshiy
Mr-Leshiy previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkioshn bkioshn requested a review from stevenj February 7, 2024 09:42
stevenj
stevenj approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkioshn bkioshn removed the review me PR is ready for review label Feb 7, 2024
@bkioshn bkioshn merged commit 91ac810 into main Feb 7, 2024
25 checks passed
@bkioshn bkioshn deleted the fix/openapi-spec branch February 7, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelipeRosa FelipeRosa FelipeRosa left review comments

@stevenj stevenj stevenj approved these changes

@Mr-Leshiy Mr-Leshiy Mr-Leshiy left review comments

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

Assignees

@bkioshn bkioshn

Labels
documentation Pull requests that update a dependency file. enhancement New feature or request
Projects
Catalyst
Archived in project
Milestone
No milestone
4 participants
@bkioshn @stevenj @FelipeRosa @Mr-Leshiy