-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get server for Openapi specification #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let add two env vars with defaults.
HTTP_AUTO_SERVERS=false
HTTPS_AUTO_SERVERS=true
and create one list for each if it's true
add another env var:
SERVER_NAME="https://www.someserver.com:1234"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be ideal if all these could be both cli parameters or env vars.
The reason is, cli parameters are easier to deal with in local testing.
But env vars are easier to deal with in deployments where we don't want to change the containers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Get list of server for Openapi specification
Related Issue(s)
Closes #143
Description of Changes
servers
in OpenAPI specification.Port
is added to the back of the url instead of in avariables
as it should be due to poem limitationhttps://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.0.md#server-object
http-auto-server
andhttps-auto-server
, flags are added in case a prefixhttp//:
,https//:
, or both are needed andserver_name
SERVER_NAME
,HTTP_AUTO_SERVERS
,HTTPS_AUTO_SERVERS
, andADDRESS
can be set through environment variableRelated Pull Requests
#208
Please confirm the following checks