Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use #1 as example issue in pr template #269

Merged
merged 3 commits into from
Feb 29, 2024
Merged

fix: Use #1 as example issue in pr template #269

merged 3 commits into from
Feb 29, 2024

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Feb 28, 2024

Description

This PR changes the example issue used in the template to #1 so we stop closing and reopening the poor #123

Related Issue(s)

List the issue numbers related to this pull request.

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@kukkok3 kukkok3 requested a review from minikin February 28, 2024 10:11
@kukkok3 kukkok3 self-assigned this Feb 28, 2024
@kukkok3 kukkok3 enabled auto-merge (squash) February 28, 2024 10:12
@minikin minikin disabled auto-merge February 29, 2024 07:46
@minikin minikin merged commit b6f89d7 into main Feb 29, 2024
2 checks passed
@minikin minikin deleted the fix/pr-template branch February 29, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants