Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kroki ci errors #298

Merged
merged 4 commits into from
Mar 8, 2024
Merged

fix: kroki ci errors #298

merged 4 commits into from
Mar 8, 2024

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Mar 8, 2024

Description

Fix docs by removing kroki diagrams.

Related Issue(s)

Closes #296

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stevenj stevenj self-assigned this Mar 8, 2024
@stevenj stevenj added bug Something isn't working documentation Pull requests that update a dependency file. labels Mar 8, 2024
@stevenj stevenj changed the title Fix/kroki ci errors fix: kroki ci errors Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Test Report | ${\color{lightgreen}Pass: 10/10}$ | ${\color{red}Fail: 0/10}$ |

Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevenj stevenj merged commit fa6cc4b into main Mar 8, 2024
24 of 25 checks passed
@stevenj stevenj deleted the fix/kroki-ci-errors branch March 8, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Pull requests that update a dependency file.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: CI broken due to flaky kroki.io server
2 participants