Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setup code generation #357

Merged
merged 12 commits into from
Mar 30, 2024
Merged

feat: setup code generation #357

merged 12 commits into from
Mar 30, 2024

Conversation

coire1
Copy link
Contributor

@coire1 coire1 commented Mar 29, 2024

Description

This PR introduces the Automated Code Generation for the catalyst_voices project using the OpenAPI specifications defined in catalyst-gateway. It orchestrates a set of earthly targets to build the OpenAPI specs, generate the code and validate the generated code consistencies on PRs.

Related Issue(s)

Closes #347

@coire1 coire1 self-assigned this Mar 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 29, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@coire1 coire1 marked this pull request as ready for review March 29, 2024 12:40
@coire1 coire1 requested a review from minikin as a code owner March 29, 2024 12:40
@coire1 coire1 added the review me PR is ready for review label Mar 29, 2024
kukkok3
kukkok3 reviewed Mar 29, 2024
View reviewed changes
catalyst_voices/Earthfile Outdated Show resolved Hide resolved
minikin
minikin requested changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails for me when I run it locally.
Here are logs.

@coire1
Copy link
Contributor Author

coire1 commented Mar 29, 2024

It fails for me when I run it locally. Here are logs.

@minikin Question to identify the issue: does it work by running earthly --platform=linux/amd64 +code-generator-local

@minikin
Copy link
Collaborator

minikin commented Mar 29, 2024

@coire1 this earthly --platform=linux/amd64 +code-generator-local command indeed works. Let's update the documentation, please.

minikin
minikin requested changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the generated code from catalyst_voices_models to catalyst_voices_services. Cat Gateway API is a service.

minikin
minikin approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 147168e into main Mar 30, 2024
26 checks passed
@minikin minikin deleted the feat/setup-code-generation branch March 30, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukkok3 kukkok3 kukkok3 left review comments

@minikin minikin minikin approved these changes

Assignees

@coire1 coire1

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Setup code generation
3 participants
@coire1 @minikin @kukkok3