Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't trigger uikit deploy needlessly #574

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

dtscalac
Copy link
Contributor

Description

UI Kit earthly target only needs to be triggered by a specific github action that consumes the target output files to deploy the app on firebase hosting. Renaming it so that it doesn't get discovered and run by catalyst-ci.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Jun 26, 2024
@dtscalac dtscalac self-assigned this Jun 26, 2024
@dtscalac dtscalac requested a review from minikin as a code owner June 26, 2024 06:57
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Test Report | ${\color{lightgreen}Pass: 91/91}$ | ${\color{red}Fail: 0/91}$ |

minikin
minikin previously approved these changes Jun 26, 2024
@dtscalac dtscalac requested a review from minikin June 26, 2024 10:23
@minikin minikin enabled auto-merge (squash) June 26, 2024 10:24
@minikin minikin merged commit 23d3480 into main Jun 26, 2024
12 checks passed
@minikin minikin deleted the fix/dont-trigger-automatically-uikit-deploy branch June 26, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants