Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues before publishing catalyst-cardano #581

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

dtscalac
Copy link
Contributor

Description

Fixes issues that prevent publishing catalyst_cardano_* and catalyst_anasysis packages to pub.dev

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels Jun 27, 2024
@dtscalac dtscalac self-assigned this Jun 27, 2024
@dtscalac dtscalac requested review from minikin and stevenj as code owners June 27, 2024 10:33
@dtscalac dtscalac changed the title fix: fix issues before publishing catalyst-cardano fix:issues before publishing catalyst-cardano Jun 27, 2024
@dtscalac dtscalac changed the title fix:issues before publishing catalyst-cardano fix: issues before publishing catalyst-cardano Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jun 27, 2024

Test Report | ${\color{lightgreen}Pass: 91/91}$ | ${\color{red}Fail: 0/91}$ |

@dtscalac dtscalac removed the dart Pull requests that update Dart code label Jun 27, 2024
minikin
minikin previously approved these changes Jun 27, 2024
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin enabled auto-merge (squash) June 27, 2024 15:13
@dtscalac dtscalac requested a review from minikin June 27, 2024 15:59
@minikin minikin merged commit 7b5338b into main Jun 27, 2024
26 checks passed
@minikin minikin deleted the feat/publish-catalyst-cardano branch June 27, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants