Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readme versioning for catalyst packages #585

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Jul 1, 2024

Description

  • Removes any explicit package versions in favor of using latest version in README files to avoid manually updating these after each release. Melos can't do it automatically.

  • Updates catalyst_voices to use catalyst_analysis from path instead of hardcoded version

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels Jul 1, 2024
@dtscalac dtscalac self-assigned this Jul 1, 2024
@dtscalac dtscalac requested review from minikin and stevenj as code owners July 1, 2024 11:57
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Test Report | ${\color{lightgreen}Pass: 91/91}$ | ${\color{red}Fail: 0/91}$ |

Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtscalac dtscalac merged commit e433b2d into main Jul 1, 2024
26 checks passed
@dtscalac dtscalac deleted the fix/readme-versioning-for-catalyst-packages branch July 1, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants