Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rbac metadata #619

Merged
merged 9 commits into from
Jul 16, 2024
Merged

feat: rbac metadata #619

merged 9 commits into from
Jul 16, 2024

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Jul 15, 2024 •
edited
Loading

Description

Adds support for Role Based Access Control Transaction Metadata to catalyst_cardano_serialization package. The scope of this PR is to build a RbacMetadata that will be serialized into cbor.

Next PRs will compress the RbacMetadata, chunk it into parts and provide these chunks as fields 10/11/12 defined in metadata-signed.

Breaking change:

  • Renamed VKey to Ed25519PublicKey as this allows the class to be used in more contexts, not only in witness set.

Documentation:

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels Jul 15, 2024
@dtscalac dtscalac self-assigned this Jul 15, 2024
@dtscalac dtscalac requested review from minikin and stevenj as code owners July 15, 2024 06:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 97/97}$ | ${\color{red}Fail: 0/97}$ |

@minikin minikin enabled auto-merge (squash) July 15, 2024 06:53
minikin
minikin reviewed Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments.

...t_voices_packages/catalyst_cardano_serialization/lib/src/rbac/role_based_access_control.dart Show resolved Hide resolved
...t_voices_packages/catalyst_cardano_serialization/lib/src/rbac/role_based_access_control.dart Outdated Show resolved Hide resolved
@dtscalac dtscalac requested a review from minikin July 16, 2024 07:44
minikin
minikin approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin merged commit daf24a1 into main Jul 16, 2024
14 checks passed
@minikin minikin deleted the feat/rbac_metadata branch July 16, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikin minikin minikin approved these changes

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M3: Backend and Wallet Integration Up...
Development

Successfully merging this pull request may close these issues.
2 participants
@dtscalac @minikin