Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: signData return type should be DataSignature, not VkeyWitness #647

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

dtscalac
Copy link
Contributor

Description

Fixes wrong return type from CIP-30 signData method. The data is encoded as JSON, not as CBOR.

Expected result in example app after calling signData:
Screenshot 2024-07-31 at 10 25 34

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels Jul 31, 2024
@dtscalac dtscalac self-assigned this Jul 31, 2024
@dtscalac dtscalac requested review from minikin and stevenj as code owners July 31, 2024 08:27
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 105/105}$ | ${\color{red}Fail: 0/105}$ |

@minikin minikin enabled auto-merge (squash) July 31, 2024 09:00
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin merged commit 69dba1d into main Jul 31, 2024
35 checks passed
@minikin minikin deleted the fix/sign-data-return-type branch July 31, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants