Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add code owners, update project dic #66

Merged
merged 1 commit into from
Oct 16, 2023
Merged

feat: add code owners, update project dic #66

merged 1 commit into from
Oct 16, 2023

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Oct 16, 2023

Description

  • add code owners

Related Issue(s)

Closes #8

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@minikin minikin requested a review from stevenj October 16, 2023 10:36
@minikin minikin self-assigned this Oct 16, 2023
@minikin minikin requested a review from cong-or October 16, 2023 10:36
@minikin minikin enabled auto-merge (squash) October 16, 2023 10:36
@minikin minikin added the review me PR is ready for review label Oct 16, 2023
stevenj
stevenj approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@minikin minikin merged commit d2a48ed into main Oct 16, 2023
3 checks passed
@minikin minikin deleted the feature/add-codeowners branch October 16, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@cong-or cong-or Awaiting requested review from cong-or

Assignees

@minikin minikin

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS
2 participants
@minikin @stevenj