-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: COSE_SIGN1 signatures and verification #669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generated files from linter
…ices into feat/cose-sign1-and-verify
# Conflicts: # .config/dictionaries/project.dic
dtscalac
added
review me
PR is ready for review
dart
Pull requests that update Dart code
labels
Aug 7, 2024
✅ Test Report | |
minikin
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds catalyst_cose, a package that exposes a CBOR Object Signing and Encryption RFC-9052, RFC-9053 implementation.
This package supports only a subset of COSE features and algorithms.
Supported features:
Supported algorithms:
Description of changes
The PR removes support for federated plugin structure, instead of relying on 3rd party packages to implement it per platform we have created our own pure dart implementation that works on every target (web, mobile, desktop).
Naturally we won't have support for as many algorithms as these 3rd parties could provide but thanks to this approach we don't need some huge/complicated node.js dependencies for web and native ones for Android/ios. Adding more algorithms should be straightforward enough.
Related Issue(s)
Closes #639
Screenshots
Sample generated COSE_SIGN1 structure:
Please confirm the following checks