Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flutter integration tests #672

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix: flutter integration tests #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ce5b29
fix: flutter integration tests
kukkok3 Aug 8, 2024
b9d45a6
fix: remove secret check
kukkok3 Aug 8, 2024
13082a4
Merge branch 'main' into fix-flutter-integration-tests
minikin Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions catalyst_voices/Earthfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,11 @@ test-unit:
# Build web version of Catalyst Voices
build-web:
FROM +builder
ARG SECRETS_ARE_AVAILABLE=false
ARG SENTRY_DSN

IF [$SECRETS_ARE_AVAILABLE]
ARG WORKDIR=/frontend/catalyst_voices
DO flutter-ci+BUILD_WEB --TARGET=lib/configs/main_web.dart --dart-define SENTRY_DSN=$SENTRY_DSN --WORKDIR=$WORKDIR
SAVE ARTIFACT web
ELSE
RUN echo "No secrets are available in Earthly yet."
END
ARG WORKDIR=/frontend/catalyst_voices
DO flutter-ci+BUILD_WEB --TARGET=lib/configs/main_web.dart --dart-define SENTRY_DSN=$SENTRY_DSN --WORKDIR=$WORKDIR
SAVE ARTIFACT web

package:
FROM nginx:alpine3.18
Expand Down
8 changes: 3 additions & 5 deletions catalyst_voices/test_driver/Earthfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ VERSION 0.8

IMPORT ../ AS catalyst-voices

# TODO(kukko3) - fix and enable
disabled-integration-test-web:
integration-test-web:
FROM catalyst-voices+build-web
ARG TARGETARCH
ARG browser
Expand Down Expand Up @@ -38,8 +37,7 @@ disabled-integration-test-web:
exit 1
END

# TODO(kukko3) - fix and enable
disabled-test-web-all:
BUILD +disabled-integration-test-web \
test-web-all:
BUILD +integration-test-web \
--browser=chrome \
--browser=firefox
Loading