Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uikit text fields #689

Merged
merged 6 commits into from
Aug 14, 2024
Merged

feat: uikit text fields #689

merged 6 commits into from
Aug 14, 2024

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Aug 14, 2024 •
edited
Loading

Description

Adds custom Text fields.

Related Issue(s)

Closes #657

Screenshots

Screen.Recording.2024-08-14.at.11.57.55.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code UI Kit Reusable UI components (widgets) labels Aug 14, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Aug 14, 2024
@dtscalac dtscalac self-assigned this Aug 14, 2024
@dtscalac dtscalac requested a review from minikin as a code owner August 14, 2024 09:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 148/148}$ | ${\color{red}Fail: 0/148}$ |

@dtscalac dtscalac changed the title Feat/uikit text fields feat: uikit text fields Aug 14, 2024
@minikin minikin merged commit f19f957 into main Aug 14, 2024
39 checks passed
@minikin minikin deleted the feat/uikit-text-fields branch August 14, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikin minikin minikin approved these changes

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code review me PR is ready for review UI Kit Reusable UI components (widgets)
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Text Field
2 participants
@dtscalac @minikin