Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: poc local storage #704

Merged
merged 25 commits into from
Aug 20, 2024
Merged

feat: poc local storage #704

merged 25 commits into from
Aug 20, 2024

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Aug 20, 2024

Description

⚠️ Important: This pull request should not be the subject of a code review, and the code should not be used in production.

  • The user's password is hashed with the Argon2 algorithm and stored locally.
  • The certificates are encrypted and decrypted using the AES-GCM algorithm and stored in local storage in binary format.
  • To access the 'Protected Screen' always requires a user password.
  • Web app is available: https://poc-catalyst-local-web-storage.web.app/ (Chrome in private mode is recommended for testing)
  • Webapp was tested using Zap. The results can be seen in the screenshots section.

Related Issue(s)

Resolves #644

Additional Notes

  • Haching, encryption, and decryption are performed on the main thread so UI can be a bit slow.
  • All other improvements regarding code quality, moving CPU-intensive operations to web workers/isolates, and bug fixes are out of this PR's scope.

Breaking Changes

No

Screenshots

CleanShot.2024-08-20.at.13.33.28.mp4

CleanShot 2024-08-19 at 16 52 48
CleanShot 2024-08-19 at 16 52 14
CleanShot 2024-08-19 at 16 52 04

@minikin minikin self-assigned this Aug 20, 2024
Copy link
Contributor

github-actions bot commented Aug 20, 2024

Test Report | ${\color{lightgreen}Pass: 150/150}$ | ${\color{red}Fail: 0/150}$ |

@minikin minikin requested a review from stevenj August 20, 2024 11:36
Update cspell.json

Revert "Update cspell.json"

This reverts commit 93fc2740e00b2d2c6ea98a863d4e6cef6280300e.
stevenj
stevenj previously approved these changes Aug 20, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin enabled auto-merge (squash) August 20, 2024 13:35
@minikin minikin disabled auto-merge August 20, 2024 14:35
@minikin minikin merged commit d990131 into main Aug 20, 2024
36 checks passed
@minikin minikin deleted the feat/poc-local-storage branch August 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Develop local storage PoC
2 participants