-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Adds Rust CI/CD and Refactors Cataylst gateway to be passing (minus unit tests). #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p inside tree still todo.
… db interface logic
…ion by splitting into multiple logical units.
…ts fully internalized now.
stevenj
added
enhancement
New feature or request
review me
PR is ready for review
labels
Oct 20, 2023
stevenj
added this to the M1: Open Source Setup & Initial Voting Module Deployments to Testnet milestone
Oct 20, 2023
stevenj
requested review from
Mr-Leshiy,
FelipeRosa,
cong-or and
saibatizoku
as code owners
October 20, 2023 12:08
minikin
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevenj
I've approved this PR.
Moving forward, I propose we aim for more concise PRs.
Smaller PRs can streamline the review process and save time for everyone involved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for contributing to the project!
Please fill out this template to help us review your changes.
This is currently linked to a pre-release of the rust tooling defined in
catalyst-ci
.That will be changed in a separate PR once the upstream code merges.
Related Issue(s)
List the issue numbers related to this pull request.
cat-data-service
migration #41cat-gateway
passes Clippy pedantic lints and Documentation checks. #43cat-gateway
is properly building its deployable container in CI #44Description of Changes
Catalyst Gateway
Breaking Changes
Tests currently do not pass since they are blocked on refactoring the DB setup.
See:
cat-gateway
must be resiliant in the face of DB schema changes #46cat-gateway
health endpoint to probe schema version #47cat-gateway
DB Migratiosn to be able to run in a incremental, or Drop and reload fashion. #48cat-gateway
needs to be locally deployable for testing. #49This should still be merged even with the tests broken, and they can be corrected in a followup.
Please confirm the following checks