Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): Add "No Internet Connection Banner" widget #827

Merged
merged 21 commits into from
Sep 17, 2024

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Sep 17, 2024

Description

Add the "No Internet Connection" widget including the code, example, and localization for the widget.

Related Issue(s)

Closes #734

Screenshots

The screenshots were taken from uikit_example in the "indicator" section.

Screenshot 2024-09-17 at 22 01 24 Screenshot 2024-09-17 at 22 00 20

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added the review me PR is ready for review label Sep 17, 2024
@apskhem apskhem added this to the M4: Voting & Delegation milestone Sep 17, 2024
@apskhem apskhem self-assigned this Sep 17, 2024
@apskhem apskhem requested a review from minikin as a code owner September 17, 2024 11:14
@apskhem apskhem linked an issue Sep 17, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Test Report | ${\color{lightgreen}Pass: 209/209}$ | ${\color{red}Fail: 0/209}$ |

@dtscalac
Copy link
Contributor

dtscalac commented Sep 17, 2024

I'm not sure about the condition for maxWidth but it was not defined as strict requirement so hard to judge if that's the correct value.

final shouldButtonDisplay = constraints.maxWidth > 744;

Theoretically better approach would be to use ResponsiveBuilder instead of hardcoding the breakpoint (744) and manually using LayoutBuilder. Consider to improve it in the next PR.

LGTM

@dtscalac dtscalac merged commit 458a83b into main Sep 17, 2024
34 of 36 checks passed
@dtscalac dtscalac deleted the feat/no-connection-banner branch September 17, 2024 20:33
@dtscalac dtscalac added ux/ui UX/UI related issues dart Pull requests that update Dart code UI Kit Reusable UI components (widgets) labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review UI Kit Reusable UI components (widgets) ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : No internet connection banner
2 participants