-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cat-voices): Add "No Internet Connection Banner" widget #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Test Report | |
dtscalac
reviewed
Sep 17, 2024
catalyst_voices/uikit_example/lib/examples/voices_indicators_example.dart
Outdated
Show resolved
Hide resolved
dtscalac
reviewed
Sep 17, 2024
catalyst_voices/lib/widgets/indicators/voices_no_internet_connection_banner.dart
Outdated
Show resolved
Hide resolved
dtscalac
reviewed
Sep 17, 2024
catalyst_voices/lib/widgets/indicators/voices_no_internet_connection_banner.dart
Outdated
Show resolved
Hide resolved
dtscalac
reviewed
Sep 17, 2024
catalyst_voices/lib/widgets/indicators/voices_no_internet_connection_banner.dart
Outdated
Show resolved
Hide resolved
dtscalac
reviewed
Sep 17, 2024
catalyst_voices/lib/widgets/indicators/voices_no_internet_connection_banner.dart
Show resolved
Hide resolved
dtscalac
reviewed
Sep 17, 2024
catalyst_voices/lib/widgets/indicators/voices_no_internet_connection_banner.dart
Outdated
Show resolved
Hide resolved
I'm not sure about the condition for maxWidth but it was not defined as strict requirement so hard to judge if that's the correct value. final shouldButtonDisplay = constraints.maxWidth > 744; Theoretically better approach would be to use LGTM |
dtscalac
approved these changes
Sep 17, 2024
dtscalac
added
ux/ui
UX/UI related issues
dart
Pull requests that update Dart code
UI Kit
Reusable UI components (widgets)
labels
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the "No Internet Connection" widget including the code, example, and localization for the widget.
Related Issue(s)
Closes #734
Screenshots
The screenshots were taken from
uikit_example
in the "indicator" section.Please confirm the following checks