Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(endpoints): Add 'POST /v0/message' endpoint #95

Merged
merged 8 commits into from
Oct 30, 2023
Merged

feat(endpoints): Add 'POST /v0/message' endpoint #95

merged 8 commits into from
Oct 30, 2023

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Oct 29, 2023 •
edited
Loading

Description

POST /v0/message endpoint scaffolding in the service, and full documentation of all parameters and return payloads.

Related Issue(s)

Resolves #54

Description of Changes

Adds MessageApi to the API components.
Defines and implements POST /message endpoint.
Defines and implements FragmentsProcessingSummary return payload.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added the enhancement New feature or request label Oct 29, 2023
@saibatizoku saibatizoku added this to the M4: Voting & Delegation milestone Oct 29, 2023
@saibatizoku saibatizoku self-assigned this Oct 29, 2023
@saibatizoku saibatizoku linked an issue Oct 29, 2023 that may be closed by this pull request
🛠️ [TASK] : Compatibility Voting Endpoint /api/v0/message #54
Closed
@saibatizoku saibatizoku changed the title Feature/message endpoint feat(endpoints): Add 'POST /message' endpoint Oct 29, 2023
@saibatizoku saibatizoku force-pushed the feature/message-endpoint branch from a362f23 to 1eab23a Compare October 29, 2023 19:36
@saibatizoku saibatizoku marked this pull request as ready for review October 29, 2023 19:37
@minikin minikin enabled auto-merge (squash) October 30, 2023 08:45
@minikin minikin added the review me PR is ready for review label Oct 30, 2023
@saibatizoku saibatizoku requested a review from Mr-Leshiy October 30, 2023 17:29
@saibatizoku saibatizoku changed the title feat(endpoints): Add 'POST /message' endpoint feat(endpoints): Add 'POST /v0/message' endpoint Oct 30, 2023
@saibatizoku saibatizoku force-pushed the feature/message-endpoint branch from 4f87337 to 89c95d6 Compare October 30, 2023 17:30
@saibatizoku saibatizoku force-pushed the feature/message-endpoint branch from 89c95d6 to f8f225f Compare October 30, 2023 17:32
@saibatizoku saibatizoku force-pushed the feature/message-endpoint branch from 57fdbb8 to e40ba08 Compare October 30, 2023 17:49
Mr-Leshiy
Mr-Leshiy approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit d7ea02c into main Oct 30, 2023
6 checks passed
@minikin minikin deleted the feature/message-endpoint branch October 30, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@minikin minikin Awaiting requested review from minikin

Assignees

@saibatizoku saibatizoku

Labels
enhancement New feature or request review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Compatibility Voting Endpoint /api/v0/message
3 participants
@saibatizoku @Mr-Leshiy @minikin