Change the AST representation of CTree to use "Trees that grow"
#96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/unify-asts
branch
2 times, most recently
from
20f577c to
8c2caac
Compare
Soupstraw
changed the title
CTree to use "Trees that grow"
Soupstraw
requested review from
jasagredo and
nc6
and removed request for
jasagredo
Soupstraw
force-pushed
the
jj/unify-asts
branch
from
b681669 to
9b3a530
Compare
Soupstraw
force-pushed
the
jj/unify-asts
branch
from
ad847e1 to
4a858b9
Compare
lehins
approved these changes
Oct 10, 2025
| type instance CTreeExt OrReferenced = OrRef (CTree OrReferenced) | ||
|
|
||
| -- | Indicates that an item may be referenced rather than defined. | ||
| data OrRef a |
There was a problem hiding this comment.
Is this type parameter still needed?
Suggested change
| data OrRef a | |
| data OrRef |
| deriving (Show) | ||
|
|
||
| deriving instance Eq (OrRef (CTree OrRef)) => Eq NameResolutionFailure | ||
| deriving instance Eq (CTree.Node OrReferenced) => Eq NameResolutionFailure |
There was a problem hiding this comment.
This constraint should not be necessary. It is fully saturated and Eq for Node is not an orphan instance
Suggested change
| deriving instance Eq (CTree.Node OrReferenced) => Eq NameResolutionFailure | |
| deriving instance Eq NameResolutionFailure |
|
|
||
| data OrReferenced | ||
|
|
||
| type instance CTreeExt OrReferenced = OrRef (CTree OrReferenced) |
There was a problem hiding this comment.
See my comment below
Suggested change
| type instance CTreeExt OrReferenced = OrRef (CTree OrReferenced) | |
| type instance CTreeExt OrReferenced = OrRef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the representation of the
CTreeAST to trees that grow. This is a step towards having a single AST representation across the entire repo.I got rid of the fixpoint decorations by adding a
CTreeEconstructor to theCTreedatatype, which can be used to store each of the different references by choosing the right index type. This approach of with the index can also be later used to add additional fields to the terms (e.g. for storing custom generators or comments for each term).