Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -iog-full flavor (with R and Postgres) #129

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Add -iog-full flavor (with R and Postgres) #129

merged 1 commit into from
Mar 21, 2024

Conversation

yvan-sraka
Copy link
Contributor

No description provided.

@yvan-sraka yvan-sraka requested a review from angerman March 13, 2024 11:08
@yvan-sraka yvan-sraka self-assigned this Mar 13, 2024
angerman
angerman requested changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit backwards from the logic? Can we make this to rather be withIOGFat? to have IOG + instead of IOG - ?

@yvan-sraka yvan-sraka changed the title Add -iog-slim flavor (without R and Postgres) Add -iog-full flavor (with R and Postgres) Mar 19, 2024
@yvan-sraka yvan-sraka requested a review from angerman March 19, 2024 13:05
@yvan-sraka yvan-sraka marked this pull request as ready for review March 19, 2024 13:05
angerman
angerman approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvan-sraka yvan-sraka added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 9a480f9 Mar 21, 2024
48 checks passed
@yvan-sraka yvan-sraka deleted the iog-slim branch March 21, 2024 13:40
@sgillespie sgillespie mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

Assignees

@yvan-sraka yvan-sraka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvan-sraka @angerman