Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(ci): Add "-iog-full" to github CI #133

Merged
merged 1 commit into from
Apr 2, 2024
Merged

feature(ci): Add "-iog-full" to github CI #133

merged 1 commit into from
Apr 2, 2024

Conversation

sgillespie
Copy link
Contributor

No description provided.

@sgillespie sgillespie force-pushed the main branch 6 times, most recently from 5da18ae to 580f4f8 Compare April 1, 2024 13:55
@sgillespie sgillespie force-pushed the main branch 2 times, most recently from cb56c65 to 992270e Compare April 1, 2024 17:09
@sgillespie sgillespie marked this pull request as ready for review April 1, 2024 17:09
yvan-sraka
yvan-sraka reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@yvan-sraka yvan-sraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't know if you also want to update the DevContainer accordingly (I can also do it myself). If so, you'll want to edit these lines: https://github.com/input-output-hk/devx/pull/133/files#diff-0a05cff8cc9752973d3540bab193c97f35885edfdf28d2c065188cbc798a8383R137-R144

@sgillespie
Copy link
Contributor Author

LGTM! I don't know if you also want to update the DevContainer accordingly (I can also do it myself). If so, you'll want to edit these lines: https://github.com/input-output-hk/devx/pull/133/files#diff-0a05cff8cc9752973d3540bab193c97f35885edfdf28d2c065188cbc798a8383R137-R144

That's a great question! I wasn't sure if that makes sense or not, since there are relatively few people working on db-sync (and thus need postgresql). Let me know what you think, and I'll try to update it in another PR

@sgillespie sgillespie added this pull request to the merge queue Apr 2, 2024
Merged via the queue into input-output-hk:main with commit e489b1b Apr 2, 2024
742 of 750 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvan-sraka yvan-sraka yvan-sraka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgillespie @yvan-sraka