IOHasBufFS interface for I/O using user-supplied buffers
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
3 times, most recently
from
2fa9bf4 to
acc91a6
Compare
jorisdral
changed the title
ioHasBufFSIOHasBufFS interface for I/O using user-supplied buffers
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
from
acc91a6 to
6f17aa7
Compare
jorisdral
commented
Mar 6, 2024
|
Marked as draft again because of #46 (comment) |
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
11 times, most recently
from
4d894a5 to
6438163
Compare
|
Alright, |
|
Drafting this again, since we're planning on using |
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
from
6438163 to
ffceeae
Compare
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
4 times, most recently
from
335c12a to
44675ec
Compare
dcoutts
approved these changes
Mar 14, 2024
jorisdral
force-pushed
the
jdral/preadbuf-preadwrite
branch
from
44675ec to
752bb64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require this interface in https://github.com/input-output-hk/lsm-tree, because going through
ByteStringis incompatible with the code in some places, and it's costly to allocate intermediateByteStrings instead of moving around bytes from/toPtrs (andByteArrays orMutableByteArrays)Two notes:
HasFS(for now), since I don't want to break downstream code yet.fs-sim, but will be after a future PR that I'm already working on. I'm currently hunting a persistent bug in the pure model used for the state-machine tests. For now, I've included a couple of simple round-trip tests that exercise the new functions