Skip to content

all library components that use backpack should be compiled with -j1 #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chessai opened this issue Sep 17, 2019 · 7 comments
Closed
Labels

Comments

@chessai
Copy link
Contributor

chessai commented Sep 17, 2019

GHC cannot perform typechecking on "backpackified" code in parallel. All components affected must be built with -j1. Cabal seems smart enough to infer this and does the right thing (inserts -j1), but both haskell.nix and nixpkgs pass the same number to -j (i think $NIX_BUILD_CORES?), which causes a build-time failure (GHC sees -jN where N > 1 and aborts with an error message).

Backpack typechecking not supported with -j
@chessai
Copy link
Contributor Author

chessai commented Sep 17, 2019

Of course, users can override this pretty easily on a per-package basis, but it would be nice if they didn't have to; especially since this would affect pre-built caches of hackage due to avoidable build failures.

@angerman
Copy link
Collaborator

I completely missed this issue. Let's try to fix it with #244 together.

@chessai
Copy link
Contributor Author

chessai commented Sep 30, 2019

Thank you!

@Ericson2314
Copy link

Ericson2314 commented Nov 7, 2019

I wrote https://gitlab.haskell.org/ghc/ghc/merge_requests/1823 which allows -j with backpack. I have 8.8 and 8.6 backports already. An 8.10 backport should be no problem either.

@chessai
Copy link
Contributor Author

chessai commented Nov 7, 2019

@Ericson2314 I'll have to try that out! That's great!

@Ericson2314
Copy link

Knock on wood, but I think https://gitlab.haskell.org/ghc/ghc/merge_requests/1823 will finally be merged soon.

@stale
Copy link

stale bot commented Sep 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 28, 2022
@stale stale bot closed this as completed Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants