Fetch the revised cabal files as part of elaborating hackage.nix #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabedini
force-pushed
the
fix-stackage
branch
from
1ae62b9 to
e554458
Compare
andreabedini
force-pushed
the
fix-stackage
branch
from
ec85971 to
abb090e
Compare
This was referenced Mar 13, 2023
Merged
|
Merged in #1882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1857.
When we call cabal-plan-to-nix, we obtain the set of revised cabal files directly from the plan (which, in turn, are obtained from the index tarball). A stackage snapshot does not involve any planning and simply refers to specific hackage revisions (intentified by their hash and number). In this case we still need to obtain the revised cabal file from hackage before building packages.
Rather than putting this logic back in the builder (as it was before #1775), I suggest we put it into the layer that processes hackage.nix. The reason is that the builder should be agnostic about where a package comes from; in constrast, while processing hackage, we can be sure about where packages are from!