nixpkgs 20.09 pkg-config has a prefix #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From nixpkgs 20.09, the pkg-config exe has a prefix matching the ghc one
From nixpkgs 20.09, the pkg-config exe has a prefix matching the ghc one
michaelpj
reviewed
Oct 12, 2020
Collaborator
michaelpj
left a comment
michaelpj
left a comment
There was a problem hiding this comment.
Seems fine. I haven't really been following the way this stuff works in nixpkgs: is it really expected that every package manually prefixes these tools with the target prefix? That seems annoying...
builder/comp-builder.nix
Outdated
|
|
||
| # From nixpkgs 20.09, the pkg-config exe has a prefix matching the ghc one | ||
| pkgConfigHasPrefix = !(lib.strings.hasPrefix "19." lib.nixpkgsVersion | ||
| || lib.strings.hasPrefix "20.03" lib.nixpkgsVersion); |
Collaborator
There was a problem hiding this comment.
Can't we do one of those version comparison thingys we do elsewhere, e.g. versionLessThan "20.09"?
michaelpj
approved these changes
Oct 12, 2020
Apparently compareVersions treats the string "pre" in version differently. For details see https://nixos.org/manual/nix/stable/#ssec-version-comparisons
mrBliss
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Oct 12, 2020
This will include the patch that was added in input-output-hk/haskell.nix#874 to fix this issue: ``` Setup: The program 'pkg-config' version >=0.9.0 is required but it could not be found. builder for '/nix/store/16bf6j2f1fig368pi1yfv70x5njs8d6y-cardano-crypto-class-lib-cardano-crypto-class-2.0.0-x86_64-w64-mingw32.drv' failed with exit code 1 ```
mrBliss
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Oct 12, 2020
This will include the patch that was added in input-output-hk/haskell.nix#874 to fix this issue: ``` Setup: The program 'pkg-config' version >=0.9.0 is required but it could not be found. builder for '/nix/store/16bf6j2f1fig368pi1yfv70x5njs8d6y-cardano-crypto-class-lib-cardano-crypto-class-2.0.0-x86_64-w64-mingw32.drv' failed with exit code 1 ```
mrBliss
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Oct 16, 2020
This will include the patch that was added in input-output-hk/haskell.nix#874 to fix this issue: ``` Setup: The program 'pkg-config' version >=0.9.0 is required but it could not be found. builder for '/nix/store/16bf6j2f1fig368pi1yfv70x5njs8d6y-cardano-crypto-class-lib-cardano-crypto-class-2.0.0-x86_64-w64-mingw32.drv' failed with exit code 1 ```
mrBliss
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Oct 16, 2020
This will include the patch that was added in input-output-hk/haskell.nix#874 to fix this issue: ``` Setup: The program 'pkg-config' version >=0.9.0 is required but it could not be found. builder for '/nix/store/16bf6j2f1fig368pi1yfv70x5njs8d6y-cardano-crypto-class-lib-cardano-crypto-class-2.0.0-x86_64-w64-mingw32.drv' failed with exit code 1 ```
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
From nixpkgs 20.09, the pkg-config exe has a prefix matching the ghc one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From nixpkgs 20.09, the pkg-config exe has a prefix matching the ghc one