feat: Hermes event queue and Hermes reactor #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeRosa
reviewed
Mar 1, 2024
FelipeRosa
reviewed
Mar 5, 2024
* fix(hermes): changes requested for event queue * fix(hermes): Reintroduce mechanism to advise runtime extensions of a new context * fix(hermes): fix code format
Yes we did in the latest changes. |
saibatizoku
previously approved these changes
Mar 8, 2024
8 tasks
FelipeRosa
approved these changes
Mar 10, 2024
saibatizoku
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HermesEventQueueimplementation as a mpsc FIFO queue. This struct is s singleton object which is stores as a staticOnceCellvariable.HermesReactorstruct, which should a general manager which orchestrates all hermes execution like: running and stepping runtime extensions; initialising and holding an event queue instance and manages event loop thread.Related Issue(s)
#125