Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logger #186

Merged
merged 40 commits into from
Mar 29, 2024
Merged

feat: logger #186

merged 40 commits into from
Mar 29, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Mar 20, 2024 •
edited
Loading

Description

Implement logging functionality

Related Issue(s)

Closes #85

Description of Changes

Implement logging functionality using tracing

  • Specify log level (Trace, Debug, Info, Warn, Error)
  • Display JSON format for log
  • Replace TODO with logging
  • Log build info when starting the app using build-info
  • Implement logging API

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn marked this pull request as draft March 20, 2024 15:09
@bkioshn bkioshn self-assigned this Mar 20, 2024
@bkioshn bkioshn added enhancement New feature or request draft Draft labels Mar 20, 2024
@bkioshn bkioshn added this to the M2: Hermes Foundations milestone Mar 20, 2024
stevenj
stevenj requested changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK so far, some small changes requested.

hermes/bin/src/main.rs Outdated Show resolved Hide resolved
hermes/bin/src/main.rs Outdated Show resolved Hide resolved
apskhem
apskhem reviewed Mar 26, 2024
View reviewed changes
hermes/bin/Cargo.toml Outdated Show resolved Hide resolved
@bkioshn bkioshn requested a review from apskhem March 27, 2024 06:28
minikin
minikin previously requested changes Mar 27, 2024
View reviewed changes
hermes/bin/src/logger.rs Outdated Show resolved Hide resolved
@bkioshn bkioshn requested a review from minikin March 27, 2024 09:22
saibatizoku
saibatizoku previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Mr-Leshiy
Mr-Leshiy reviewed Mar 28, 2024
View reviewed changes
hermes/Cargo.toml Outdated Show resolved Hide resolved
hermes/bin/Cargo.toml Outdated Show resolved Hide resolved
hermes/bin/build.rs Show resolved Hide resolved
hermes/bin/src/logger.rs Show resolved Hide resolved
hermes/bin/src/main.rs Outdated Show resolved Hide resolved
hermes/bin/src/runtime_extensions/mod.rs Show resolved Hide resolved
@bkioshn bkioshn requested a review from Mr-Leshiy March 28, 2024 09:42
stevenj
stevenj previously approved these changes Mar 28, 2024
View reviewed changes
FelipeRosa
FelipeRosa previously approved these changes Mar 28, 2024
View reviewed changes
Copy link

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion but overall LGTM

hermes/bin/src/main.rs Outdated Show resolved Hide resolved
@Mr-Leshiy Mr-Leshiy dismissed stale reviews from FelipeRosa and stevenj via dfb8d3f March 29, 2024 07:42
@Mr-Leshiy
Update hermes/bin/src/main.rs
dfb8d3f 
Co-authored-by: Felipe Rosa <felipe.rosa@iohk.io>
Mr-Leshiy
Mr-Leshiy approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj dismissed minikin’s stale review March 29, 2024 08:53

changes requested made

@stevenj stevenj merged commit 1807df6 into main Mar 29, 2024
23 checks passed
@stevenj stevenj deleted the feat/logger branch March 29, 2024 08:55
@bkioshn bkioshn removed the review me PR is ready for review label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj stevenj approved these changes

@FelipeRosa FelipeRosa FelipeRosa left review comments

@saibatizoku saibatizoku saibatizoku left review comments

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@apskhem apskhem Awaiting requested review from apskhem

@minikin minikin Awaiting requested review from minikin minikin is a code owner

Assignees

@bkioshn bkioshn

Labels
enhancement New feature or request
Projects
Catalyst
Archived in project
Milestone
M2: Hermes Foundations
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Logging utility API: Hermes Implementation (Rust Module)
7 participants
@bkioshn @saibatizoku @stevenj @FelipeRosa @minikin @Mr-Leshiy @apskhem