Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: logging util api in C #190

Closed
wants to merge 65 commits into from
Closed

test: logging util api in C #190

wants to merge 65 commits into from

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Mar 29, 2024

Description

Implement test in C for Logging utility API

Related Issue(s)

Closes #85

Description of Changes

  • Update rust builder related version
  • Create integration test written in C on hermes logger api
    • Testing whether it is callable

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn added enhancement New feature or request review me PR is ready for review and removed draft Draft labels Apr 3, 2024
@bkioshn bkioshn marked this pull request as ready for review April 3, 2024 09:12
@bkioshn bkioshn marked this pull request as draft April 3, 2024 10:49
@bkioshn bkioshn added draft Draft and removed review me PR is ready for review labels Apr 3, 2024
@bkioshn bkioshn marked this pull request as ready for review April 3, 2024 14:08
@bkioshn bkioshn added review me PR is ready for review and removed draft Draft labels Apr 4, 2024
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj closed this Apr 5, 2024
@github-actions github-actions bot deleted the test/logger branch May 20, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Logging utility API: Hermes Implementation (Rust Module)
3 participants