feat: Change pallas dep to the catalyst-pallas fork's catalyst branch specific commit
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Leshiy
requested review from
stevenj,
FelipeRosa,
cong-or,
saibatizoku and
minikin
as code owners
minikin
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
pallasdep to thecatalyst-pallasfork'scatalystbranch specific commit.catalystbranch would our upstream branch with all our updates which are not merged to thepallasmain branch yet.Also specified a commit instead of branch to make a more reliable and robust build, so any changes inside
catalystbranch will not affect to the hermes without explicit updating of the this dependency.