Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply our Rust builder for wasm-preview-adapter crates #58

Merged
merged 42 commits into from
Jan 30, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Jan 11, 2024

Description

  • Applied our general Rust builder procedure for wasm-preview-adapter crate.
  • Fixed (actually mostly disabled) clippy lints
  • Fixed formatting.

Related Issue(s)

Part of #20

Description of Changes

Related Pull Requests

input-output-hk/catalyst-ci#140

@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review January 12, 2024 14:01
@Mr-Leshiy Mr-Leshiy mentioned this pull request Jan 24, 2024
4 tasks
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review January 24, 2024 17:28
LICENSE-APACHE Outdated Show resolved Hide resolved
@minikin minikin added the review me PR is ready for review label Jan 26, 2024
* refactor(wasm): Refactor wasm component adapter and wasi/wit code

* fix(wasm): Fix code format

* fix(wasm): Update standard WASI .wit files to latest version

* fix(wasm): Cleanup WASM wit definitions and remove things not compatible with Hermes.

* fix(wasm): Fix code format

* fix(spelling): Fix spelling check for wasm code

* feat(spelling): Add target to help build words lists

* fix(wasm): Fix code format

* fix(wasm): Use relative path to wit files so we don;t need symlink

* feat(wasm): Rewrite cron module and introduce basic hermes modules.  Others need re-writing

* fix(spelling): Fix spellcheck errors
@stevenj stevenj enabled auto-merge (squash) January 30, 2024 07:06
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj dismissed stale reviews from minikin and bkioshn January 30, 2024 07:07

resolved

@stevenj stevenj merged commit 6b8f26a into main Jan 30, 2024
11 checks passed
@stevenj stevenj deleted the feat/wasm-api branch January 30, 2024 07:08
@Mr-Leshiy Mr-Leshiy mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants