Skip to content

Conversation

@Alenar
Copy link
Collaborator

@Alenar Alenar commented Feb 9, 2024

Content

This PR create a new shared crate, mithril-persistence. All all store & database related code from mithril-common has been moved to it.

This makes enhance our code base maintainability, reduce the dependencies of the mithril-common crate, allow to remove its database feature.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1492.

@Alenar Alenar self-assigned this Feb 9, 2024
@Alenar Alenar force-pushed the djo/1492/mithril-db-crate branch from da13e6d to d846961 Compare February 9, 2024 17:11
@Alenar Alenar requested review from jpraynaud and removed request for ghubertpalo February 9, 2024 17:11
@github-actions
Copy link

github-actions bot commented Feb 9, 2024

Test Results

  3 files  ±0   37 suites  +1   9m 8s ⏱️ +34s
828 tests ±0  828 ✅ ±0  0 💤 ±0  0 ❌ ±0 
913 runs  ±0  913 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 535ba5a. ± Comparison against base commit f31f1ec.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview February 9, 2024 17:18 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 9, 2024 17:18 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/1492/mithril-db-crate branch from d846961 to 38274e7 Compare February 9, 2024 17:20
@Alenar Alenar temporarily deployed to testing-preview February 9, 2024 17:32 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 9, 2024 17:32 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left few comments for typos below. Also, should we bump the minor version of mithril-common as we changed the available features in the crate?

@Alenar
Copy link
Collaborator Author

Alenar commented Feb 12, 2024

Also, should we bump the minor version of mithril-common as we changed the available features in the crate?

Yup, bumping the minor version of mithril-common was on my mind .

@Alenar Alenar force-pushed the djo/1492/mithril-db-crate branch from 38274e7 to f2aedf1 Compare February 12, 2024 13:51
@Alenar Alenar temporarily deployed to testing-preview February 12, 2024 17:20 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 12, 2024 17:20 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/1492/mithril-db-crate branch from f2aedf1 to e029a20 Compare February 12, 2024 17:23
@Alenar Alenar force-pushed the djo/1492/mithril-db-crate branch from e029a20 to 535ba5a Compare February 12, 2024 17:30
@Alenar Alenar temporarily deployed to testing-preview February 13, 2024 08:34 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 13, 2024 08:34 — with GitHub Actions Inactive
@Alenar Alenar merged commit 141d0ad into main Feb 13, 2024
@Alenar Alenar deleted the djo/1492/mithril-db-crate branch February 13, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract database feature from common crate

4 participants