Skip to content

Upgrade mithril-explorer, www and www-test dependencies #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlachaume merged 2 commits into from
Jun 19, 2024
Merged

Upgrade mithril-explorer, www and www-test dependencies #1765

dlachaume merged 2 commits into from
Jun 19, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 18, 2024 •
edited
Loading

Content

This PR includes an upgrade of mithril-explorer, www and www-test dependencies (including patched version 8.17.1 for ws)

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@github-actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

Test Results

    4 files  ±0     51 suites  ±0   8m 48s ⏱️ +7s
1 073 tests ±0  1 073 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 221 runs  ±0  1 221 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit dead12e. ± Comparison against base commit d4fcd5c.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview June 18, 2024 10:45 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 18, 2024 10:45 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/upgrade-wasm-js-projects-dependencies branch from 9d22a70 to c2b84e1 Compare June 18, 2024 12:12
@dlachaume dlachaume self-assigned this Jun 18, 2024
@dlachaume dlachaume changed the title Upgrade www and www-test dependencies Upgrade mithril-explorer, www and www-test dependencies Jun 18, 2024
jpraynaud
jpraynaud approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume temporarily deployed to testing-preview June 18, 2024 12:40 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 18, 2024 12:40 — with GitHub Actions Inactive
dlachaume added 2 commits June 18, 2024 16:59
@dlachaume
chore: upgrade www and www-test dependencies
7057c9e 
By running 'make upgrade-www-deps'.
@dlachaume
chore: upgrade explorer dependencies
dead12e 
By running 'make upgrade'.
@dlachaume dlachaume force-pushed the dlachaume/upgrade-wasm-js-projects-dependencies branch from c2b84e1 to dead12e Compare June 18, 2024 15:01
@dlachaume dlachaume temporarily deployed to testing-preview June 18, 2024 15:09 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 18, 2024 15:09 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 7bd11e1 into main Jun 19, 2024
@dlachaume dlachaume deleted the dlachaume/upgrade-wasm-js-projects-dependencies branch June 19, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dlachaume @Alenar @jpraynaud